min-height on table is not honored
Categories
(Core :: Layout: Tables, defect)
Tracking
()
People
(Reporter: steve.patco, Assigned: emilio)
References
()
Details
(Keywords: css1, webcompat:needs-diagnosis)
Attachments
(5 files, 5 obsolete files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0
Steps to reproduce:
visit my site https://galzilla.com/index.php/blog/ in FF, the chrome and edge
Actual results:
Header image window is too small
Expected results:
Window for image should match image size
Edge and Chrome work correctly
Reporter | ||
Comment 1•5 years ago
|
||
chrome to the right and FF to the left
Reporter | ||
Comment 2•5 years ago
|
||
Just so you dont tell me that one is desktop and the other is android.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 3•5 years ago
|
||
Reporter | ||
Comment 4•5 years ago
|
||
Isnt anyone going to address this issue?
Reporter | ||
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Hi Steve,
I'm unabe to enter the link provided.
I've tried chrome, ff beta 79.0b7 (64-bit) and ff nightly 80.0a1 (2020-07-13) (64-bit), I'm seeing the attached error.
Please confirm if you still need us to investigate in this issue, and check on your site so I can try to replicate on my end.
Thanks for the report.
Best regards, Clara.
Comment 6•5 years ago
|
||
Reporter | ||
Comment 7•5 years ago
|
||
https://galzilla.com/index.php/blog/ works for me with no errors loading
Reporter | ||
Comment 8•5 years ago
|
||
I use CC allow in my firewall. You are probably outside the zone
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment 11•5 years ago
•
|
||
Hi Steve,
I was just able to access the link provided using connected to VPN USA; my apologies for the delay.
I was able to reproduce on windows 10 pro, on the following versions
Firefox Nightly version 80.0a1 (2020-07-14) (64-bit),
Beta 79.0b7
Release 78.0.2 (64-bit)
It doesn't happen in Chrome.
Setting a component for this issue in order to get the dev team involved.
Thanks for the report.
Best regards, Clara
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 12•5 years ago
|
||
(In reply to steve.patco from comment #0)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0
Steps to reproduce:
visit my site https://galzilla.com/index.php/blog/ in FF, the chrome and edge
Actual results:
Header image window is too small
Expected results:
Window for image should match image size
Edge and Chrome work correctly
Be aware, CC_allow US CA MX only in CSF firewall
Updated•5 years ago
|
Comment 13•5 years ago
|
||
Potentially looks like more of a layout issue, so have moved components.
Reporter | ||
Comment 14•5 years ago
|
||
Interesting discovery. If I remove the slogan text from the header image, the image will completely disappear.
Reporter | ||
Comment 15•5 years ago
|
||
Well ALMOST disappear. No slogan will reduce image to a single line of visibility.
Assignee | ||
Comment 16•5 years ago
|
||
Is there any chance that you can attach an HTML file that reproduces the issue to the bug, using the "attach file" button?
That way europeans like me don't need to go out of our way to investigate this :-)
Reporter | ||
Comment 17•5 years ago
|
||
I can adjust the firewall to add dominant countries if you tell me your CC
Assignee | ||
Comment 18•5 years ago
|
||
I'm in Spain (ES) right now
Assignee | ||
Comment 19•5 years ago
|
||
This is about whether min-height
is applied on tables. Test-case incoming.
Assignee | ||
Comment 20•5 years ago
|
||
Reporter | ||
Comment 21•5 years ago
|
||
So I noticed that the browser source code shows <!-- and --> over a good amount of code inside the Style tag. This is supposedly for the benefit of old browsers. It renders the code as comments. I am wondering if this is contributing to the problem.
Comment 22•5 years ago
|
||
I notice this can be reproduced on mac. Change this from Windows to All
Assignee | ||
Comment 23•5 years ago
|
||
I have a patch btw, just need to take some time to fix some tests that depend on our current behavior.
Assignee | ||
Comment 24•5 years ago
|
||
Does this fix part or all of bug 307866?
Comment 26•5 years ago
•
|
||
Please add a box-sizing: content-box
test as well, unless we already have that somewhere. I think this test renders correctly with your patch. (Chrome fails the min-height
test AFAICT).
Comment 27•5 years ago
|
||
(added a couple of max-height/width
tests)
Assignee | ||
Comment 28•5 years ago
|
||
(In reply to David Baron :dbaron: 🏴 ⌚UTC-8 from comment #25)
Does this fix part or all of bug 307866?
Only part, for the table box itself, not tbody and so on I think.
Comment 29•5 years ago
|
||
Comment 31•5 years ago
|
||
Comment 32•5 years ago
|
||
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2d42454f13e124183d0444c00b5f60ca3c56b865&failure_classification_id=2&selectedTaskRun=Bi3ZjihdRyuNaMlyTgWmGg.0
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=310568760&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=310565904&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/dc056be018fe
Assignee | ||
Comment 33•5 years ago
|
||
So the android test is an unexpected pass. But the other one is an osx-only failure in layout/generic/test/test_bug1642588.html. The bug seems pre-existing, here's the reasoning, though I cannot reproduce the failure neither on Linux nor OSX with the patch applied.
So that test is doing something like the attached test-case. After that, the test double-clicks, then backspaces. But it turns out that before my patch that backspace made the table zero-height, and after my patch it (correctly) doesn't. It probably ended up somehow messing with the selection. But you can see clearly how after double-clicking and back-spacing the selection gets completely messed up.
Kagami, you seem to have written that test, are you ok with commenting out the table test-case with a follow-up on file for it? Or should I file the bug about the broken selection and disable the test on OSX? I can't repro and I'm pretty sure the root cause is pre-existing...
Assignee | ||
Comment 34•5 years ago
|
||
Reporter | ||
Comment 35•5 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #33)
Created attachment 9165178 [details]
Table contenteditable test.So the android test is an unexpected pass. But the other one is an osx-only failure in layout/generic/test/test_bug1642588.html. The bug seems pre-existing, here's the reasoning, though I cannot reproduce the failure neither on Linux nor OSX with the patch applied.
So that test is doing something like the attached test-case. After that, the test double-clicks, then backspaces. But it turns out that before my patch that backspace made the table zero-height, and after my patch it (correctly) doesn't. It probably ended up somehow messing with the selection. But you can see clearly how after double-clicking and back-spacing the selection gets completely messed up.
Kagami, you seem to have written that test, are you ok with commenting out the table test-case with a follow-up on file for it? Or should I file the bug about the broken selection and disable the test on OSX? I can't repro and I'm pretty sure the root cause is pre-existing...
My site still does not pass on my android.
Assignee | ||
Comment 36•5 years ago
|
||
With which version of Firefox have you tried? The patch hasn't landed because it failed a test, so unless you've built firefox yourself with the patch it's not really surprising.
Comment 37•5 years ago
|
||
Comment 38•5 years ago
|
||
Comment 39•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e366e119efa0
https://hg.mozilla.org/mozilla-central/rev/2d3509d767bb
Updated•5 years ago
|
Updated•5 years ago
|
Description
•