Bugzilla

I think we should not land this patch as is.

This patch removes the empty *_ESDH functions from cmslocal.h and cmspubkey.c - this seems fine.

This patch also removes a block of code from cmsrecinfo.c - we shouldn't do that.
David's patch in bug requires that block of code, and it changes it to handle SEC_OID_ANSIX962_EC_PUBLIC_KEY.

David's patch keeps the calls to the _ESDH function, he attempts to make no changes to existing code.

Because there's consensus in this bug here that the _ESDH code isn't working and can be removed, I suggest that we amend David's patch to remove/disable the case that handles SEC_OID_X942_DIFFIE_HELMAN_KEY - after David's patch landed.

I think we should not land this patch as is.

This patch removes the empty *_ESDH functions from cmslocal.h and cmspubkey.c - this seems fine.

This patch also removes a block of code from cmsrecinfo.c - we shouldn't do that.
David's patch in bug requires that block of code, and it changes it to handle SEC_OID_ANSIX962_EC_PUBLIC_KEY.

David's patch keeps the calls to the _ESDH function, he attempts to make no changes to existing code (handling of other algorithms).

Because there's consensus in this bug here that the _ESDH code isn't working and can be removed, I suggest that we amend David's patch to remove/disable the case that handles SEC_OID_X942_DIFFIE_HELMAN_KEY - after David's patch landed.

I think we should not land this patch as is.

This patch removes the empty *_ESDH functions from cmslocal.h and cmspubkey.c - this seems fine.

This patch also removes a block of code from cmsrecinfo.c - we shouldn't do that.
David's patch in bug requires that block of code, and it changes it to handle SEC_OID_ANSIX962_EC_PUBLIC_KEY.

David's patch keeps the call to the _ESDH function, he attempts to make no changes to existing code (handling of other algorithms).

Because there's consensus in this bug here that the _ESDH code isn't working and can be removed, I suggest that we amend David's patch to remove/disable the case that handles SEC_OID_X942_DIFFIE_HELMAN_KEY - after David's patch landed.