Remove imcomplete Ephemeral-Static DH support from libsmime (CMSUtil_EncryptSymKey_ESDH)

REOPENED
Unassigned

Status

NSS
Libraries
REOPENED
7 years ago
4 years ago

People

(Reporter: briansmith, Unassigned)

Tracking

(Depends on: 2 bugs, {crash})

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [See comment 2 before checking in; more work may be needed])

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #668397 +++

In particular, remove the code in the cases of the switch statements that call NSS_CMSUtil_*_ESDH and remove the NSS_CMSUtil_*_ESDH functions, as this code can't work and thus hasn't been tested, AFAICT.
Created attachment 545469 [details] [diff] [review]
Remove ESDH support

Here is the patch. Notice that this code always failed because NSS_CMSUtil_EncryptSymKey_ESDH unconditionally returned SECFailure. Also, NSS_CMSUtil_DecryptSymKey_ESDH was never called.
Assignee: nobody → bsmith
Attachment #545469 - Flags: review?(rrelyea)

Comment 2

7 years ago
Comment on attachment 545469 [details] [diff] [review]
Remove ESDH support

There are two other SEC_OID_X942_DIFFIE_HELMAN_KEY cases
in security/nss/lib/smime/cmsrecinfo.c.  Should we also
remove them?
In bug 676118, David Cooper contributed an ESDH implementation, so I am resolving this as a duplicate of that bug.
Severity: major → normal
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Depends on: 676118
Resolution: --- → DUPLICATE
Duplicate of bug: 676118
This code was supposed to implement ephemeral-static non-ECC DH, David's patches are for ephemeral-staic ECC DH. So, it still makes sense to keep this bug open to remove this dead code.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---

Comment 5

6 years ago
Comment on attachment 545469 [details] [diff] [review]
Remove ESDH support

r+ with the following caveat....

ECDH and DH should be very similiar (basically differing in some mechanisms and oids).

Most of the underlying mechanical differences should not appear at this layer.

This patch should be coordinated with David Cooper's work on ECC.

bob
Attachment #545469 - Flags: review?(rrelyea) → review+
Whiteboard: [See comment 2 before checking in; more work may be needed]
Assignee: brian → nobody
You need to log in before you can comment on or make changes to this bug.