Bug 1523263 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Note that bug 9037574 just added this, so if it's a recent crash, that's probably the cause.
  https://bugzilla.mozilla.org/attachment.cgi?id=9037574&action=diff

My assumption I had from reading the code was that these flags simply reflect the about:config flags and are *further* gated by IonCanCompile()/BaselineCanCompile() so this patch wouldn't have been necessary, but maybe I missed something...

On a side note, in bug 9037574,  I was also mystified as to how we're deserializing an IDB module given that IDB serialization is disabled entirely.  It's quite possible (given the low volume) that someone's just running mochitests manually, one of which contains a profile containing a wasm module stored in IDB (to test this path).  Otherwise, it means someone is using a profile which managed to store wasm in IDB *on another architecture* before bug 1469395 removed the ability to do so, which seems unlikely.  Note that bug 1487479 will remove IDB databases containing wasm entirely which will remove this whole case.
Note that bug 1521058 just added this, so if it's a recent crash, that's probably the cause.
  https://bugzilla.mozilla.org/attachment.cgi?id=9037574&action=diff

My assumption I had from reading the code was that these flags simply reflect the about:config flags and are *further* gated by IonCanCompile()/BaselineCanCompile() so this patch wouldn't have been necessary, but maybe I missed something...

On a side note, in bug 9037574,  I was also mystified as to how we're deserializing an IDB module given that IDB serialization is disabled entirely.  It's quite possible (given the low volume) that someone's just running mochitests manually, one of which contains a profile containing a wasm module stored in IDB (to test this path).  Otherwise, it means someone is using a profile which managed to store wasm in IDB *on another architecture* before bug 1469395 removed the ability to do so, which seems unlikely.  Note that bug 1487479 will remove IDB databases containing wasm entirely which will remove this whole case.
Note that bug 1521058 just added this, so if it's a recent crash, that's probably the cause.
  https://bugzilla.mozilla.org/attachment.cgi?id=9037574&action=diff

My assumption I had from reading the code was that these flags simply reflect the about:config flags and are *further* gated by IonCanCompile()/BaselineCanCompile() so this patch wouldn't have been necessary, but maybe I missed something...

On a side note, in bug 1521058,  I was also mystified as to how we're deserializing an IDB module given that IDB serialization is disabled entirely.  It's quite possible (given the low volume) that someone's just running mochitests manually, one of which contains a profile containing a wasm module stored in IDB (to test this path).  Otherwise, it means someone is using a profile which managed to store wasm in IDB *on another architecture* before bug 1469395 removed the ability to do so, which seems unlikely.  Note that bug 1487479 will remove IDB databases containing wasm entirely which will remove this whole case.

Back to Bug 1523263 Comment 7