Bug 1580280 Comment 14 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Hey Nick,

This patch gets `mach lint` running with Python. I got backed out over the `android-lints` (forgot to test them) hitting this line:
https://searchfox.org/mozilla-central/rev/f43ae7e1c43a4a940b658381157a6ea6c5a185c1/build/moz.configure/init.configure#319

I guess gradle invokes configure at some point. Interestingly, that line shouldn't get hit in automation, but under Python 3 it does. I'm having a bit of difficulty figuring out where that value comes from, do you have any insight?

Although even after fixing that, I suspect we might run into other problems. I might need to create a little shim that runs the `android-lints` in a Python 2 subprocess :/
Hey Nick,

This patch gets `mach lint` running with Python 3. I got backed out over the `android-lints` (forgot to test them) hitting this line:
https://searchfox.org/mozilla-central/rev/f43ae7e1c43a4a940b658381157a6ea6c5a185c1/build/moz.configure/init.configure#319

I guess gradle invokes configure at some point. Interestingly, that line shouldn't get hit in automation, but under Python 3 it does. I'm having a bit of difficulty figuring out where that value comes from, do you have any insight?

Although even after fixing that, I suspect we might run into other problems. I might need to create a little shim that runs the `android-lints` in a Python 2 subprocess :/
Hey Nick,

This patch gets `mach lint` running with Python 3. I got backed out over the `android-lints` (forgot to test them) hitting this line:
https://searchfox.org/mozilla-central/rev/f43ae7e1c43a4a940b658381157a6ea6c5a185c1/build/moz.configure/init.configure#319

I guess gradle invokes configure at some point. Interestingly, that line shouldn't get hit in automation, but under Python 3 it does. I'm having a bit of difficulty figuring out where that `automation` value comes from, do you have any insight?

Although even after fixing that, I suspect we might run into other problems. I might need to create a little shim that runs the `android-lints` in a Python 2 subprocess :/

Back to Bug 1580280 Comment 14