(In reply to Daisuke Akatsuka (:daisuke) from comment #1) > One thing. > The above test works for current m-c. But, if we apply a patch of bug 1665908, the last assertion (one-off button is still selected) would be failed since one-off button will be unselected whenever entering search mode. It should not unselect the one-off button because it should just be search mode preview, not full search mode (that is where we unselect the oneoff button). The difference is that if you just cycle through one-off buttons with the keyboard is search mode preview, if you confirm with Enter then it should be full search mode.
Bug 1668430 Comment 3 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Daisuke Akatsuka (:daisuke) from comment #1) > One thing. > The above test works for current m-c. But, if we apply a patch of bug 1665908, the last assertion (one-off button is still selected) would be failed since one-off button will be unselected whenever entering search mode. ~~It should not unselect the one-off button because it should just be search mode preview, not full search mode (that is where we unselect the oneoff button). The difference is that if you just cycle through one-off buttons with the keyboard is search mode preview, if you confirm with Enter then it should be full search mode.~~