Closed Bug 1668430 Opened 4 years ago Closed 4 years ago

Add test about search mode and one-off button behavior when typing search engine alias after selecting one of one-off button.

Categories

(Firefox :: Address Bar, task, P3)

task
Points:
1

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: daisuke, Assigned: daisuke)

References

Details

Attachments

(1 file)

This is a follow-up of bug 1665908.

As Marco advised in phabricator, we should test about search mode and one-off button behavior when typing search engine alias after selecting one of one-off button into browser_searchMode_alias_replacement.js.
The test case Marco suggested is following:

  1. Select one of one-off button
  2. Type a valid alias (like "@alias sometext")

Then, check it is not converted into a different search mode and one-off button is still selected.

(In reply to Daisuke Akatsuka (:daisuke) from comment #0)

The test case Marco suggested is following:

  1. Select one of one-off button
  2. Type a valid alias (like "@alias sometext")

Then, check it is not converted into a different search mode and one-off button is still selected.

One thing.
The above test works for current m-c. But, if we apply a patch of bug 1665908, the last assertion (one-off button is still selected) would be failed since one-off button will be unselected whenever entering search mode.
So, Assuming that the patch of bug 1665908 is applied, add the test.

Severity: -- → S3
Points: --- → 1
Priority: -- → P3

Ah, I see what you mean, when we start typing we confirm search mode and that clears the one-off.
Thanks for pointing that out.

Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5e046f6d0e25
Add a test about search mode when typing an alias after selecting one-off button. r=mak
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: