Bug 1798561 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
D157947 refactored SMA SHOW_MIGRATION_WIZARD handling call to be asynchronous for Windows and Linux platform.  

However with possibility of SHOW_MIGRATION_WIZARD as one of action in MULTI_ACTION,  we do need a reliable way for Import Wizard to wait for migration to finish before navigating to next screen which needs  SHOW_MIGRATION_WIZARD handler to be a promise or add a call to wait in the handler similar to AWWaitForMigrationClose. 

https://searchfox.org/mozilla-central/rev/a3decf626dabd89620171f0ea7840cc4351fe218/browser/components/newtab/content-src/aboutwelcome/components/MultiStageAboutWelcome.jsx#322

https://phabricator.services.mozilla.com/D157947
https://phabricator.services.mozilla.com/D160861
Revision 1 by
on 
D157947 refactored SMA SHOW_MIGRATION_WIZARD handling call to be asynchronous for Windows and Linux platform.  

However with possibility of SHOW_MIGRATION_WIZARD as one of action in MULTI_ACTION,  we do need a reliable way in onboarding to wait for Import Wizard migration to finish before navigating to next screen. This needs  SHOW_MIGRATION_WIZARD handler to be a promise or add a call similar to AWWaitForMigrationClose to allow wait in the handler 

https://searchfox.org/mozilla-central/rev/a3decf626dabd89620171f0ea7840cc4351fe218/browser/components/newtab/content-src/aboutwelcome/components/MultiStageAboutWelcome.jsx#322

https://phabricator.services.mozilla.com/D157947
https://phabricator.services.mozilla.com/D160861
Revision 2 by
on 
D157947 refactored SMA SHOW_MIGRATION_WIZARD handling call to be asynchronous for Windows and Linux platform.  

However with possibility of SHOW_MIGRATION_WIZARD as one of action in MULTI_ACTION,  we do need a reliable way in onboarding to wait for Import Wizard migration to finish before navigating to next screen. This needs  SHOW_MIGRATION_WIZARD handler to be a promise or add a call similar to AWWaitForMigrationClose to allow wait in the handler before returning

https://searchfox.org/mozilla-central/rev/a3decf626dabd89620171f0ea7840cc4351fe218/browser/components/newtab/content-src/aboutwelcome/components/MultiStageAboutWelcome.jsx#322

https://phabricator.services.mozilla.com/D157947
https://phabricator.services.mozilla.com/D160861

Back to Bug 1798561 Comment 0