1025579 - [b2g][emulator] explicitly handle the timeout issue for permission request test cases

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Explicitly catch timeout issue in permission request test cases for investigating Bug 984274 and Bug 1019572.

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: handle-timeout-permission-request.patch

catch the timeout issue in test case instead of waiting for test harness timeout.

https://tbpl.mozilla.org/?tree=Try&rev=7bd8d3ef191f

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8440398 [details] [diff] [review]
handle-timeout-permission-request.patch

Review of attachment 8440398 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a bit worried about b2g and android servers. Sometimes they are slow and using timeouts can be a problem.
Can you put the '5000' in a test preference?

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: pref-timeout-value.patch

@baku, is this what you expected for moving 5000 to test preference?

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: handle-timeout-permission-request.patch

update patch according to review comment, carry r+.

try result: https://tbpl.mozilla.org/?tree=Try&rev=3b1305537c38

Comment 5

[Andrea Marchesini [:baku]]

schien, on try it seems we have a couple of orange issue. Can you take a look?

Comment 6

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

@baku, this patch is for providing more debug information on TBPL and for making test case fail faster than 330s timeout. In bug 984274 comment #437 @ayang found webapp updater resets the permission table during the test. If we can land bug 984274 soon then there is no need to land the patch in this bug. @baku, How do you think?

Comment 7

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Hmm...looks like we are not landing bug 984274 that soon. I'd like to land this patch for providing more debug information on these test cases. @baku and @Ryan, how do you think?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

My recollection from the Try push was that it didn't make much difference in how the results were being reported. Anyway, I'm on PTO today, so I'll defer to Andrea.

Comment 9

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

This patch is mainly for Bug 984274. I'm closing this bug as WONTFIX because we already land the fix for Bug 984274.