108965 - Remove nsXULEmitter.cpp from the build

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect, P3)

Description

[Scott MacGregor]

We have an obsolete class that's still part of the build:

nsXULEmitter.cpp/h. 

We need to remove this from the build. 

It will make a small improvment for the first message display since it will make
the emitter DLL smaller. And it will help footprint a little bit.

Comment 1

[scottputterman]

Varada can you take a look at this when you get a chance?

Comment 2

[Håkan Waara]

Attachment: Patch

This patch removes xulemitter from the build. It builds fine on Win32. Maybe we
need a mac-buddy to remove it from a .mcp file too.

mscott, varada, wanna review this?

Comment 3

[Håkan Waara]

Patch attached.  Now all that is needed is testing on linux and mac (to make
sure I didn't break the builds there) and reviews.

Comment 4

[scottputterman]

*** Bug 90246 has been marked as a duplicate of this bug. ***

Comment 5

[scottputterman]

reassigning to mscott.  It looks like this just needs a review and Varada isn't
currently around.

Comment 6

[Scott MacGregor]

Comment on attachment 57902 [details] [diff] [review]
Patch

sr=mscott

obviously we'll need mac changes to get checked in when we check this in.

Comment 7

[Scott MacGregor]

Attachment: initial patch was incomplete...remove all references to the xul emitter

Comment 8

[Jean-Francois Ducarroz]

Comment on attachment 66372 [details] [diff] [review]
initial patch was incomplete...remove all references to the xul emitter

R=ducarroz. Still need to remove nsMimeXULEmitter.cpp from mimeEmitter.xml (the
Mac project)

Comment 9

[(not reading, please use [e-mail] instead)]

Comment on attachment 66372 [details] [diff] [review]
initial patch was incomplete...remove all references to the xul emitter

sr=sspitzer

Comment 10

[Jean-Francois Ducarroz]

Attachment: complementary patch for the Mac project

Scoot, Seth, can you review it. Thanks

Comment 11

[Scott MacGregor]

thanks JF, I had made a similar change on my Mac. I'm not planning on landing
any project changes till after I remove all the code references. I'll let you
know when that's going to happen and we can land together. 

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 66404 [details] [diff] [review]
complementary patch for the Mac project

rs=sspitzer

Comment 13

[Jean-Francois Ducarroz]

I checked in the Mac part of the fix. Scott, feel free to close this bug as fixed...

Comment 14

[Brian Ryner (not reading)]

please remove the file from the tree if it's obsolete... we've got enough dead
files hanging around as it is.  thanks.

Comment 15

[Scott MacGregor]

the files have been removed from the repository.

Comment 16

[[e-mail] (gone - use [e-mail] instead)]

cvs server: mozilla/mailnews/mime/emitters/src/nsMimeXULEmitter.cpp is no longer
in the repository
cvs server: mozilla/mailnews/mime/emitters/src/nsMimeXULEmitter.h is no longer
in the repository

and I checked LXR, too.

Verified FIXED.