1091608 - |mach gtest| does not display the test result at all

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Masatoshi Kimura [:emk]]

Steps to reproduce:
  mach gtest

Actual result:
xul.dll will be relinked, but no further output after the following line:
 0:59.51 g:\m\mozilla-central\obj-i686-pc-mingw32\dist\bin\firefox.exe -unittest

Expected result:
The test result should be displayed.

|mozmake -C obj-i686-pc-mingw32/testing/gtest/| check works, but it does not relink xul.dll automatically. My workaround is |mach gtest| then |mozmake -C .../gtest/ check|.

Comment 1

[Masatoshi Kimura [:emk]]

  MOZ_RUN_GTEST=1 obj-i686-pc-mingw32/dist/bin/firefox.exe -unittest
had no display either, but
  MOZ_RUN_GTEST=1 obj-i686-pc-mingw32/dist/bin/firefox.exe -unittest | cat
worked.

Comment 2

[(not currently active) Ted Mielczarek]

Oh, this is probably just another manifestation of the "Windows console doesn't attach" problem. If you pipe stdout it works around it. Presumably running make check is piping the output but the mach command isn't.

Comment 3

[Masatoshi Kimura [:emk]]

|make check| uses rungtest.py. Bug 1050878 will help.

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Attach the console if the process is running the GTest

I don't think bug 787313 is a problem for the gtest mode.
The gtest mode is itself opt-in, is disabled in the shipped binaries, and will not even create a window.
I also fixed a bug that the -attach-console option didn't work correctly.

Comment 5

[Masatoshi Kimura [:emk]]

Try result:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=74710eb67527
(gtest is running under "B".)

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 8515027 [details] [diff] [review]
Attach the console if the process is running the GTest

Review of attachment 8515027 [details] [diff] [review]:
-----------------------------------------------------------------

This makes sense, thanks.

Comment 7

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d2c268b9063

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8d2c268b9063