1142865 - Remove the parent argument from NewObjectWithGroup

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove the parent argument from NewObjectWithGroup

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove the parent argument from NewObjectWithGroup

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 8577376 [details] [diff] [review]
Remove the parent argument from NewObjectWithGroup

Review of attachment 8577376 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/UnboxedObject.cpp
@@ +507,1 @@
>                                                                       allocKind, newKind);

UPO *res =
    NewObjectWithGroup<UPO>(...);

should amke this more readable, I think.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Done, and https://hg.mozilla.org/integration/mozilla-inbound/rev/7128e4104f94

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7128e4104f94