1166840 - Remove the document argument from the clipboard helper APIs

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[(no longer active)]

This is no longer necessary after bug 815952 was fixed.  (See bug 965199 comment 14.)

poiru, is this something that may interest you?

Comment 1

[Biru [:poiru]]

Sure, can do.

Comment 2

[Biru [:poiru]]

Attachment: Remove unused document argument in uses of nsIClipboardHelper.copyString

Comment 3

[Biru [:poiru]]

Attachment: Remove SpecialPowers.copyString in place of SpecialPowers.clipboardCopyString

Comment 4

[Biru [:poiru]]

Attachment: Remove document argument from nsIClipboardHelper.copyString{,ToClipboard}

Comment 5

[Julian Descottes]

(Adding this bug as a dependency for Bug 965199. I modified/added some calls to clipboardHelper copyString, and will update them when this fix is merged)

Comment 6

[(no longer active)]

Comment on attachment 8609184 [details] [diff] [review]
Remove document argument from nsIClipboardHelper.copyString{,ToClipboard}

Review of attachment 8609184 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: layout/base/nsDocumentViewer.cpp
@@ +2642,5 @@
>    nsCOMPtr<nsIClipboardHelper> clipboard(do_GetService("@mozilla.org/widget/clipboardhelper;1", &rv));
>    NS_ENSURE_SUCCESS(rv, rv);
>  
>    // copy the href onto the clipboard
>    nsCOMPtr<nsIDOMDocument> doc = do_QueryInterface(mDocument);

Nit: this is now unused, please remove it!

Comment 7

[(no longer active)]

(In reply to Julian Descottes from comment #5)
> (Adding this bug as a dependency for Bug 965199. I modified/added some calls
> to clipboardHelper copyString, and will update them when this fix is merged)

Thanks a lot, Julian!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b83845e4117c
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec14eee472e5
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e89159cbe38

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b83845e4117c
https://hg.mozilla.org/mozilla-central/rev/ec14eee472e5
https://hg.mozilla.org/mozilla-central/rev/9e89159cbe38