Closed
Bug 117119
Opened 23 years ago
Closed 23 years ago
BMP and ICO decoders should use ReadSegments, not Read
Categories
(Core :: Graphics: ImageLib, defect, P2)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla0.9.9
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
(Keywords: perf)
Attachments
(1 file)
4.21 KB,
patch
|
pavlov
:
review+
tor
:
superreview+
|
Details | Diff | Splinter Review |
ReadSegments is faster because it avoids a memory alloocation and copy. Will attach a patch soon.
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
Pavlov, could you review this patch? TIA
Assignee | ||
Updated•23 years ago
|
Priority: -- → P2
Target Milestone: --- → mozilla0.9.8
Comment 3•23 years ago
|
||
Comment on attachment 62885 [details] [diff] [review] Patch r=pavlov
Attachment #62885 -
Flags: review+
Comment on attachment 62885 [details] [diff] [review] Patch sr=tor
Attachment #62885 -
Flags: superreview+
Comment 5•23 years ago
|
||
This bug has r= and sr=. Hi Christian, could you request an a=
Assignee | ||
Comment 6•23 years ago
|
||
Vicente, I don't think that this patch is needed for 0.9.8, nor do I think it will get a=. I'll have somebody check it in as soon as the tree opens. Setting Target Milestone to 0.9.9. (forgot to do that earlier)
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Assignee | ||
Comment 7•23 years ago
|
||
timeless checked this in, marking fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•