1191415 - Refactor editor.js to use 4 spaces for indentation

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Peter Bengtsson [:peterbe]]

The file https://github.com/mozilla/airmozilla/blob/master/airmozilla/popcorn/static/popcorn/js/editor.js is using 2 spaces for indentation. 

I personally like 2 spaces for JS but I don't like that this one is different from all the others. Consistency is more important.

Comment 1

[anubhav.worklinux]

hey Peter. i would submit a patch soon for this one.

Comment 2

[anubhav.worklinux]

https://github.com/mozilla/airmozilla/pull/437
PR on Github

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/891be32a20be03d29a674c060a4dfab463c23c73
Fixes Bug 1191415 - Refactor editor.js to use 4 spaces for indentation

https://github.com/mozilla/airmozilla/commit/3828b82eafc5df501e0b32976834adfd77e626ac
Merge pull request #437 from anu7495/my-fix

Fixes Bug 1191415 - Refactor editor.js to use 4 spaces for indentation

Comment 4

[anubhav.worklinux]

Hii! could someone assign this bug to me as i cant do it myself so that it shows up in my bugzilla profile as resolved.
need that for college credits.
thanks!

Comment 5

[Mike Nolan [:nolski]]

Hi Anubhav,

This bug is already resolved. Thank you for the interest though!

Comment 6

[anubhav.worklinux]

Hi mike,
i meant that as i was the one who submitted the merged pull request for this bug, i just wanted that if it could show my name in AssignedTo field, so that it shows up in my profile as assigned to me and resolved by me.
thanks!