1204187 - IonMonkey: MIPS32: Inline RelocationIterator

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

Attachment: 0001-IonMonkey-MIPS32-Inline-RelocationIterator.patch

Inline RelocationIterator in Assembler::TraceJumpRelocations.

Comment 1

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8660250 [details] [diff] [review]
0001-IonMonkey-MIPS32-Inline-RelocationIterator.patch

Review of attachment 8660250 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips32/Assembler-mips32.cpp
@@ +7,5 @@
>  #include "jit/mips32/Assembler-mips32.h"
>  
> +#include "mozilla/DebugOnly.h"
> +
> +using mozilla::DebugOnly;

nit: DebugOnly does not seems required by this patch.

Comment 2

[hev [:hev]]

(In reply to Nicolas B. Pierron [:nbp] from comment #1)
> Comment on attachment 8660250 [details] [diff] [review]
> 0001-IonMonkey-MIPS32-Inline-RelocationIterator.patch
> 
> Review of attachment 8660250 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/jit/mips32/Assembler-mips32.cpp
> @@ +7,5 @@
> >  #include "jit/mips32/Assembler-mips32.h"
> >  
> > +#include "mozilla/DebugOnly.h"
> > +
> > +using mozilla::DebugOnly;
> 
> nit: DebugOnly does not seems required by this patch.

Yes, I fix a latent build issue by the way. ;)

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/862295d7d82a

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/862295d7d82a