1212969 - Copy generated API tokens hard with extra space

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

Attachment: Screenshot 2015-10-08 11.06.52.png

There is now a space between the first part and the second part of a generated token. 

See attached screenshot. NOTE! This is a screenshot FROM MY LAPTOP INSTANCE so it's not a reveal of an actual token.

Comment 1

[Peter Bengtsson [:peterbe]]

Attachment: Screenshot 2015-10-08 11.07.44.png

Notice the space when I hightlight it.

Comment 2

[Peter Bengtsson [:peterbe]]

Adrian, is this worth fixing now that we're getting the new personal/"you" page?

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

Yes, that is still important to fix, because the new Profile page only shows your list of existing tokens, but still leads you to the API Tokens page for management.

Comment 4

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3032

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/3604b02c58dd9f37a7e2d14cef6b4601ff99e4d3
fixes bug 1212969 - display copyable token without whitespace

https://github.com/mozilla/socorro/commit/b4f2a1fa6f65c5967cdfae6eb1bb22eb0779a068
Merge pull request #3032 from peterbe/bug-1212969-display-copyable-token-without-whitespace

fixes bug 1212969 - display copyable token without whitespace

Comment 6

[Peter Bengtsson [:peterbe]]

It didn't work. :(

Visually the whole token might look sane but when you paste it (after having copied it) it still has the space in it.

Comment 7

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3034

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/4eec3c4bec3a40ebfb1eff51c5e1765c405a273b
fixes bug 1212969 - show API tokens with javascript, r=AdrianGaudebert

https://github.com/mozilla/socorro/commit/4ce00f1cc15b21303217a46246ef388c1992ef81
Merge pull request #3034 from peterbe/bug-1212969-show-api-tokens-with-javascript

fixes bug 1212969 - show API tokens with javascript