1226052 - Get test_mozfiledataurl.html working with e10s

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrew McCreight [:mccr8]]

I think the getFile method is the problematic part of this tests.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Remove trailing whitespace in test_mozfiledataurl.html.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a946d43d4bb9&selectedJob=15696146

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Don't name every file 'file' in test_mozfiledataurl.html.

This will make it possible to create them in one batch later.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Create File objects in test_mozfiledataurl.html using a frame script.

For some reason this test still times out on Android and B2G, but at least it works on e10s now.

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 8710475 [details] [diff] [review]
part 2 - Don't name every file 'file' in test_mozfiledataurl.html.

Review of attachment 8710475 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/test/test_mozfiledataurl.html
@@ +103,5 @@
>    isnot(img.height, 90, "correct error height");
>  */
>    // Generate new fileurl and make sure it's different from the old
>    var oldFileurl = fileurl;
> +  var fileurl = URL.createObjectURL(audioFile);

remove 'var'

Comment 6

[Andrew McCreight [:mccr8]]

(In reply to Andrea Marchesini (:baku) from comment #5)
> remove 'var'

I've removed all of the redundant "var" for the various fileurl.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d28b1c4a6882
https://hg.mozilla.org/integration/mozilla-inbound/rev/66a382d1bc52
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e98a23b710f

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d28b1c4a6882
https://hg.mozilla.org/mozilla-central/rev/66a382d1bc52
https://hg.mozilla.org/mozilla-central/rev/7e98a23b710f