Get test_mozfiledataurl.html working with e10s

RESOLVED FIXED in Firefox 46

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 1 bug)

Trunk
mozilla46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox45 affected, firefox46 fixed)

Details

Attachments

(3 attachments)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Blocks: 1218958
No longer blocks: 1225202

Updated

2 years ago
Blocks: 984139
tracking-e10s: --- → +
(Assignee)

Comment 1

2 years ago
I think the getFile method is the problematic part of this tests.
(Assignee)

Comment 2

2 years ago
Created attachment 8710474 [details] [diff] [review]
part 1 - Remove trailing whitespace in test_mozfiledataurl.html.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a946d43d4bb9&selectedJob=15696146
Attachment #8710474 - Flags: review?(amarchesini)
(Assignee)

Comment 3

2 years ago
Created attachment 8710475 [details] [diff] [review]
part 2 - Don't name every file 'file' in test_mozfiledataurl.html.

This will make it possible to create them in one batch later.
Attachment #8710475 - Flags: review?(amarchesini)
(Assignee)

Comment 4

2 years ago
Created attachment 8710476 [details] [diff] [review]
part 3 - Create File objects in test_mozfiledataurl.html using a frame script.

For some reason this test still times out on Android and B2G, but at least it works on e10s now.
Attachment #8710476 - Flags: review?(amarchesini)
Attachment #8710474 - Flags: review?(amarchesini) → review+
Comment on attachment 8710475 [details] [diff] [review]
part 2 - Don't name every file 'file' in test_mozfiledataurl.html.

Review of attachment 8710475 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/test/test_mozfiledataurl.html
@@ +103,5 @@
>    isnot(img.height, 90, "correct error height");
>  */
>    // Generate new fileurl and make sure it's different from the old
>    var oldFileurl = fileurl;
> +  var fileurl = URL.createObjectURL(audioFile);

remove 'var'
Attachment #8710475 - Flags: review?(amarchesini) → review+
Attachment #8710476 - Flags: review?(amarchesini) → review+
(Assignee)

Comment 6

2 years ago
(In reply to Andrea Marchesini (:baku) from comment #5)
> remove 'var'

I've removed all of the redundant "var" for the various fileurl.

Comment 7

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d28b1c4a6882
https://hg.mozilla.org/integration/mozilla-inbound/rev/66a382d1bc52
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e98a23b710f

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d28b1c4a6882
https://hg.mozilla.org/mozilla-central/rev/66a382d1bc52
https://hg.mozilla.org/mozilla-central/rev/7e98a23b710f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.