Closed
Bug 1226052
Opened 10 years ago
Closed 10 years ago
Get test_mozfiledataurl.html working with e10s
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
2.66 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
5.44 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
8.17 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•10 years ago
|
Updated•10 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Assignee | ||
Comment 1•10 years ago
|
||
I think the getFile method is the problematic part of this tests.
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8710474 -
Flags: review?(amarchesini)
Assignee | ||
Comment 3•10 years ago
|
||
This will make it possible to create them in one batch later.
Attachment #8710475 -
Flags: review?(amarchesini)
Assignee | ||
Comment 4•10 years ago
|
||
For some reason this test still times out on Android and B2G, but at least it works on e10s now.
Attachment #8710476 -
Flags: review?(amarchesini)
Updated•10 years ago
|
Attachment #8710474 -
Flags: review?(amarchesini) → review+
Comment 5•10 years ago
|
||
Comment on attachment 8710475 [details] [diff] [review]
part 2 - Don't name every file 'file' in test_mozfiledataurl.html.
Review of attachment 8710475 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/base/test/test_mozfiledataurl.html
@@ +103,5 @@
> isnot(img.height, 90, "correct error height");
> */
> // Generate new fileurl and make sure it's different from the old
> var oldFileurl = fileurl;
> + var fileurl = URL.createObjectURL(audioFile);
remove 'var'
Attachment #8710475 -
Flags: review?(amarchesini) → review+
Updated•10 years ago
|
Attachment #8710476 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Andrea Marchesini (:baku) from comment #5)
> remove 'var'
I've removed all of the redundant "var" for the various fileurl.
Comment 8•10 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d28b1c4a6882
https://hg.mozilla.org/mozilla-central/rev/66a382d1bc52
https://hg.mozilla.org/mozilla-central/rev/7e98a23b710f
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•