Closed
Bug 1246031
Opened 8 years ago
Closed 8 years ago
[commands] Create a utility for obtaining platform information
Categories
(WebExtensions :: Untriaged, defect)
WebExtensions
Untriaged
Tracking
(firefox47 fixed)
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: mattw, Assigned: mattw)
References
(Blocks 1 open bug)
Details
(Whiteboard: [commands]triaged)
Attachments
(1 file, 2 obsolete files)
No description provided.
Updated•8 years ago
|
Whiteboard: [commands]triaged
Assignee | ||
Updated•8 years ago
|
Summary: Create a utility for obtaining platform information → [commands] Create a utility for obtaining platform information
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8717724 -
Flags: review?(kmaglione+bmo)
Comment 2•8 years ago
|
||
Comment on attachment 8717724 [details] [diff] [review] utility for obtaining platform information Review of attachment 8717724 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/extensions/ExtensionUtils.jsm @@ +935,5 @@ > function flushJarCache(jarFile) { > Services.obs.notifyObservers(jarFile, "flush-cache-entry", null); > } > > +function getPlatformInfo() { I'd rather avoid defining this function if it's only ever going to be used once. We could just define `PlatformInfo`, create a block scope and define the `os` and `arch` properties from that, and then freeze the `PlatformInfo` object. Or we could generate it from an immediately invoking function expression. @@ +952,5 @@ > + > + return {os, arch}; > +} > + > +const PlatformInfo = getPlatformInfo(); This should probably be `Object.freeze(getPlatformInfo())` if we're going to export it.
Attachment #8717724 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8720116 -
Flags: review?(kmaglione+bmo)
Assignee | ||
Updated•8 years ago
|
Attachment #8720116 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Updated•8 years ago
|
Attachment #8717724 -
Attachment is obsolete: true
Comment 4•8 years ago
|
||
hi, this failed to apply: patching file toolkit/components/extensions/ext-runtime.js Hunk #1 FAILED at 0 1 out of 2 hunks FAILED -- saving rejects to file toolkit/components/extensions/ext-runtime.js.rej
Flags: needinfo?(mwein)
Keywords: checkin-needed
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=42f8b09f836d
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8720429 -
Flags: review?(kmaglione+bmo)
Assignee | ||
Updated•8 years ago
|
Attachment #8720429 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Updated•8 years ago
|
Attachment #8720116 -
Attachment is obsolete: true
Flags: needinfo?(mwein)
Assignee | ||
Updated•8 years ago
|
Iteration: --- → 47.2 - Feb 22
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3e9b07b743d6
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•