1246031 - [commands] Create a utility for obtaining platform information

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Comment 1

[Matthew Wein [:mattw]]

Attachment: utility for obtaining platform information

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8717724 [details] [diff] [review]
utility for obtaining platform information

Review of attachment 8717724 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/extensions/ExtensionUtils.jsm
@@ +935,5 @@
>  function flushJarCache(jarFile) {
>    Services.obs.notifyObservers(jarFile, "flush-cache-entry", null);
>  }
>  
> +function getPlatformInfo() {

I'd rather avoid defining this function if it's only ever going to be used once. We could just define `PlatformInfo`, create a block scope and define the `os` and `arch` properties from that, and then freeze the `PlatformInfo` object. Or we could generate it from an immediately invoking function expression.

@@ +952,5 @@
> +
> +  return {os, arch};
> +}
> +
> +const PlatformInfo = getPlatformInfo();

This should probably be `Object.freeze(getPlatformInfo())` if we're going to export it.

Comment 3

[Matthew Wein [:mattw]]

Attachment: utility for obtaining platform information

Comment 4

[Carsten Book [:Tomcat]]

hi, this failed to apply:

patching file toolkit/components/extensions/ext-runtime.js
Hunk #1 FAILED at 0
1 out of 2 hunks FAILED -- saving rejects to file toolkit/components/extensions/ext-runtime.js.rej

Comment 5

[Matthew Wein [:mattw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=42f8b09f836d

Comment 6

[Matthew Wein [:mattw]]

Attachment: Utility for obtaining platform information. try: -b do -p linux64,macosx64,win32,win64 -u mochitest,xpcshell

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3e9b07b743d6

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3e9b07b743d6