Closed Bug 1281468 Opened 8 years ago Closed 8 years ago

[shipping] dashboard suggestion is open even if latest revision is rejected.

Categories

(Webtools Graveyard :: Elmo, defect)

Product:
Webtools Graveyard
Component:
Elmo
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Pike, Assigned: Pike)

Details

The action on /shipping/dashboard is still 'sign off', even if the latest revision is rejected. Action turns out to be both.

Should just be rejected.
Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/e531e40dc5455f69bde031c33729c369183fcde0
bug 1281468, don't suggest new sign-offs if last push is rejected

The problem was that we tried to ignore fallbacks by looking
at current or pending sign-offs. Which made us ignore rejected
ones.

Fix is to explicitly ignore fallback actions, which are, by
def, ACCEPTED with a fallback appversion.
This is FIXED and in production.
Assignee: nobody → l10n
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.