Closed
Bug 1289358
Opened 8 years ago
Closed 8 years ago
Remove typeof win.foo == "function" checks in CustomizableWidgets.jsm
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: dao, Unassigned, Mentored)
Details
(Whiteboard: [good first bug][lang=js])
Attachments
(1 file)
|
2.76 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
These functions should be guaranteed to exist, so the checks are pointless: https://dxr.mozilla.org/mozilla-central/search?q=file%3ACustomizableWidgets.jsm+%27%3D%3D+%22function%22%27&redirect=false
|
||
Comment 1•8 years ago
|
||
Remove checks as the functions are guaranteed to exist.
Attachment #8775745 -
Flags: review?(dao+bmo)
|
Reporter | |
Comment 2•8 years ago
|
||
Comment on attachment 8775745 [details] [diff] [review] Bug 1289358 : Remove typeof win.foo == "function" checks Looks good. Thanks!
Attachment #8775745 -
Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/7fdbf2f6db18 Remove typeof win.foo == "function" checks. r=dao
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/fx-team/rev/06e51ce8f72f Remove typeof win.foo == "function" checks: Remove trailing whitespaces. r=eslint-fix
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7fdbf2f6db18 https://hg.mozilla.org/mozilla-central/rev/06e51ce8f72f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in
before you can comment on or make changes to this bug.
Description
•