1296822 - Dimmed background is not correct

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Alice0775 White]

Attachment: screenshot

Steps To Reproduce:
1. Enable new findbar
  user_pref("findbar.highlightAll", true);
  user_pref("findbar.modalHighlight", true);
2. Open Wikipedia
   (e.g. https://en.wikipedia.org/wiki/Firefox )
3. Open Find Bar (Ctrl+F)
4. Type "mozilla" (without quotation marks) in the Find Bar
5. Scroll down

Actual Results:
Dimmed background does not render to the entire page.
i.e. Dimmed background is not enough width and height.

Expected Results:
Dimmed background should render over the entire page

Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=2edc35144ebf50ca6339e686e766e200cc4b04b8&tochange=f76b9d417a3678f840f498598d215b41f5c6616a

Suspect:
69c852865f06	Mike de Boer — Bug 1290913 - prevent flushing the layout when dimmed highlight background is constructed. r=jaws

Comment 1

[kalevibaik]

This has been corrected

Comment 2

[Alice0775 White]

(In reply to kalevibaik from comment #1)
> This has been corrected

No, This is not fixed yet.

Comment 3

[Alice0775 White]

Bug 1279695 does not fix the problem...

STR.
1. Enable new findbar
  user_pref("findbar.highlightAll", true);
  user_pref("findbar.modalHighlight", true);
2. Open Wikipedia
   (e.g. https://en.wikipedia.org/wiki/Firefox )
3. Resize browser window to w=640px, H=850px,  so that horizontal and vertical scroll bar appear.
4. Open Find Bar (Ctrl+F)
5. Type "mozilla" (without quotation marks) in the Find Bar
   --- observe, Dimmed background size
6. Scroll down
   --- observe, Dimmed background size

Actual Results:
Dimmed background does not render to the entire page.
i.e. Dimmed background is not enough Width and Height.

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to Alice0775 White from comment #3)
> Bug 1279695 does not fix the problem...

Well, this has only just merged into mozilla-central, so there's no Nighly build out yet with this in it.
Can you try it with tomorrow's Nightly?

Comment 5

[Alice0775 White]

(In reply to Mike de Boer [:mikedeboer] from comment #4)
> (In reply to Alice0775 White from comment #3)
> > Bug 1279695 does not fix the problem...
> 
> Well, this has only just merged into mozilla-central, so there's no Nighly
> build out yet with this in it.
> Can you try it with tomorrow's Nightly?

I have tested latest fx-team build. So the Bug 1279695 is included.

Comment 6

[Alice0775 White]

Attachment: screenshot

Gap at bottom and right side

tested on
https://hg.mozilla.org/mozilla-central/rev/a65b35c8e5b17c2585968974aef1da67a8c56642
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0 ID:20160826063819

Comment 7

[Mike de Boer [:mikedeboer]]

(In reply to Alice0775 White from comment #6)
> Gap at bottom and right side

Aha! That's easy to fix - I'm accounting for the scrollbar width on both sides, but that's not necessary anymore since I'm using `getRootBounds()` now.
Thanks for the screenshot!

Comment 8

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1296822 - ignore the scrollbar size when nsIDOMWindowUtils.getRootBounds is used when fetching the page size for the findbar.

Review commit: https://reviewboard.mozilla.org/r/74746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74746/

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8785593 [details]
Bug 1296822 - ignore the scrollbar size when nsIDOMWindowUtils.getRootBounds is used when fetching the page size for the findbar.

https://reviewboard.mozilla.org/r/74746/#review72988

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74516f0a4d8a
ignore the scrollbar size when nsIDOMWindowUtils.getRootBounds is used when fetching the page size for the findbar. r=jaws

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/74516f0a4d8a

Comment 12

[roxleitan]

Verified as fixed on Windows, Ubuntu and Mac OS X on the latest Nightly 52.0a1 Build ID:20160922030437