Closed Bug 1329727 Opened 7 years ago Closed 7 years ago

Move WebMetadataKit into Firefox project instead of a separate Carthage library

Categories

(Firefox for iOS :: Browser, defect, P1)

Other
iOS
defect

Tracking

()

RESOLVED FIXED
Iteration:
1.15

People

(Reporter: sleroux, Assigned: farhan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [MobileAS])

Attachments

(2 files)

55 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review
55 bytes, text/x-github-pull-request
Details | Review
Building WebMetadataKit as a Carthage dependency was an small experiment in seeing if it made sense to pull out some pieces of our code into smaller, reusable components. Turns out it's been a bit of a pain to keep track of versions while Firefox is the only consumer of this library. I'd suggest we pull this back into the project - either port the files directly or build it as a framework within Firefox.
Blocks: 1314387
Assignee: nobody → fpatel
Iteration: --- → 1.14
Priority: P2 → P1
Attached file Pull Request
Attachment #8829978 - Flags: review?(sleroux)
Attachment #8829978 - Flags: review?(sleroux) → review+
Iteration: 1.14 → 1.15
Attached file Pull Request
Same as the above attachment. Updated to swift 3
https://github.com/mozilla-mobile/firefox-ios/pull/2424/commits/ca3c44dc81181a0688238d67d48e89305b3738af
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: