Move WebMetadataKit into Firefox project instead of a separate Carthage library

RESOLVED FIXED

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sleroux, Assigned: farhan)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MobileAS])

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Building WebMetadataKit as a Carthage dependency was an small experiment in seeing if it made sense to pull out some pieces of our code into smaller, reusable components. Turns out it's been a bit of a pain to keep track of versions while Firefox is the only consumer of this library. I'd suggest we pull this back into the project - either port the files directly or build it as a framework within Firefox.
(Assignee)

Updated

2 years ago
Blocks: 1314387
(Assignee)

Updated

2 years ago
Assignee: nobody → fpatel
Iteration: --- → 1.14
Priority: P2 → P1
(Assignee)

Comment 1

2 years ago
Created attachment 8829978 [details] [review]
Pull Request
Attachment #8829978 - Flags: review?(sleroux)
(Reporter)

Updated

2 years ago
Attachment #8829978 - Flags: review?(sleroux) → review+

Updated

2 years ago
Iteration: 1.14 → 1.15
(Assignee)

Comment 2

2 years ago
Created attachment 8837273 [details] [review]
Pull Request

Same as the above attachment. Updated to swift 3
(Assignee)

Comment 3

2 years ago
https://github.com/mozilla-mobile/firefox-ios/pull/2424/commits/ca3c44dc81181a0688238d67d48e89305b3738af
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.