Closed
Bug 1335337
Opened 7 years ago
Closed 7 years ago
Remove nsNativeTheme::IsButtonTypeMenu
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: annevk, Assigned: mstange)
References
Details
Attachments
(1 file)
<button type=menu>test</button> has special rendering on macOS due to nsNativeTheme::IsButtonTypeMenu existing. That's a bug. Potentially a leftover from an earlier removal? Discovered in https://github.com/whatwg/html/issues/237.
|
||
Comment 2•7 years ago
|
||
I've added a reftest for this in https://github.com/w3c/web-platform-tests/pull/4769
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8836148 -
Flags: review?(enndeakin)
|
||
Updated•7 years ago
|
Attachment #8836148 -
Flags: review?(enndeakin) → review+
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/370de9349dd0 Restrict special <button type="menu"> theming to XUL <button> elements. r=Enn
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/370de9349dd0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Updated•7 years ago
|
Assignee: nobody → mstange
You need to log in
before you can comment on or make changes to this bug.
Description
•