141397 - Ensure Mozilla extensions begin with -moz-

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is intended to be a semipermanent bug that gets dealt with every few
milestones but never gets marked fixed.  It is, in a sense, a continuation of
bug 3935.

We should continue to audit the CSS properties, values, units, pseudo-classes,
and pseudo-elements that Mozilla supports to make sure that all extensions begin
with -moz-, and to ensure that properties that we don't support correctly are
disabled or changed to -moz-.

Given more testing or the stabilization of CSS3 drafts (to CR, or perhaps
late-stage WD if they're known to be stable), we can also start adding support
for non -moz-ed keywords back in (e.g., 'inline-table' and 'inline-block', if
they're tested and bugs are fixed).  We can add this easily for keywords while
keeping the -moz- support by duplicating keywords in nsCSSProps.cpp (with care
as to the order).  I'd need to look at how to do it for properties, but I think
it can be done without too much difficulty.


The current issues I can think of off the top of my head, from bug 3935, are
that we support a bunch of CSS3 selectors and 'text-align: start', and also
support one unit without -moz- (I think 'ch').

Comment 1

[Madhur Bhatia]

cc'ing myself

Comment 2

[Boris Zbarsky [:bzbarsky]]

Are there any cases still in need of fixing that we know of?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I just noticed :first-node and :last-node.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch for :first-node and :last-node (checked in to trunk, 2004-04-07 16:25 -0700)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 145508 [details] [diff] [review]
patch for :first-node and :last-node (checked in to trunk, 2004-04-07 16:25 -0700)

r+sr=bzbarsky

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 145508 [details] [diff] [review]
patch for :first-node and :last-node (checked in to trunk, 2004-04-07 16:25 -0700)

This should have been fixed as part of a Mozilla1.0 blocker (bug 3935).

Comment 7

[chris hofmann]

Comment on attachment 145508 [details] [diff] [review]
patch for :first-node and :last-node (checked in to trunk, 2004-04-07 16:25 -0700)

a=chofmann for 1.7

Comment 8

[Kai de Leeuw]

shouldn't this bug be marked as RESOLVED FIXED?

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

No.  Read comment 0.  And in general, read comment 0 on any bug before
commenting on it.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think having a bug open on this is no longer useful.  I think we've been pretty good about ensuring this as part of the review process.