Ensure Mozilla extensions begin with -moz-

RESOLVED FIXED in mozilla1.7final

Status

()

Core
CSS Parsing and Computation
P1
normal
RESOLVED FIXED
15 years ago
6 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({fixed1.7})

Trunk
mozilla1.7final
fixed1.7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [whitebox])

Attachments

(1 obsolete attachment)

(Assignee)

Description

15 years ago
This is intended to be a semipermanent bug that gets dealt with every few
milestones but never gets marked fixed.  It is, in a sense, a continuation of
bug 3935.

We should continue to audit the CSS properties, values, units, pseudo-classes,
and pseudo-elements that Mozilla supports to make sure that all extensions begin
with -moz-, and to ensure that properties that we don't support correctly are
disabled or changed to -moz-.

Given more testing or the stabilization of CSS3 drafts (to CR, or perhaps
late-stage WD if they're known to be stable), we can also start adding support
for non -moz-ed keywords back in (e.g., 'inline-table' and 'inline-block', if
they're tested and bugs are fixed).  We can add this easily for keywords while
keeping the -moz- support by duplicating keywords in nsCSSProps.cpp (with care
as to the order).  I'd need to look at how to do it for properties, but I think
it can be done without too much difficulty.


The current issues I can think of off the top of my head, from bug 3935, are
that we support a bunch of CSS3 selectors and 'text-align: start', and also
support one unit without -moz- (I think 'ch').
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.1beta

Comment 1

15 years ago
cc'ing myself
(Assignee)

Updated

15 years ago
Target Milestone: mozilla1.1beta → mozilla1.2alpha

Updated

15 years ago
Whiteboard: [dev notes]

Updated

15 years ago
Whiteboard: [dev notes] → [whitebox]
Are there any cases still in need of fixing that we know of?
(Assignee)

Comment 3

13 years ago
I just noticed :first-node and :last-node.
(Assignee)

Comment 4

13 years ago
Created attachment 145508 [details] [diff] [review]
patch for :first-node and :last-node (checked in to trunk, 2004-04-07 16:25 -0700)
(Assignee)

Updated

13 years ago
Whiteboard: [whitebox] → [whitebox][patch]
Target Milestone: mozilla1.2alpha → mozilla1.7final
(Assignee)

Updated

13 years ago
Attachment #145508 - Flags: superreview?(bzbarsky)
Attachment #145508 - Flags: review?(bzbarsky)
Comment on attachment 145508 [details] [diff] [review]
patch for :first-node and :last-node (checked in to trunk, 2004-04-07 16:25 -0700)

r+sr=bzbarsky
Attachment #145508 - Flags: superreview?(bzbarsky)
Attachment #145508 - Flags: superreview+
Attachment #145508 - Flags: review?(bzbarsky)
Attachment #145508 - Flags: review+
(Assignee)

Comment 6

13 years ago
Comment on attachment 145508 [details] [diff] [review]
patch for :first-node and :last-node (checked in to trunk, 2004-04-07 16:25 -0700)

This should have been fixed as part of a Mozilla1.0 blocker (bug 3935).
Attachment #145508 - Flags: approval1.7?

Comment 7

13 years ago
Comment on attachment 145508 [details] [diff] [review]
patch for :first-node and :last-node (checked in to trunk, 2004-04-07 16:25 -0700)

a=chofmann for 1.7
Attachment #145508 - Flags: approval1.7? → approval1.7+
(Assignee)

Updated

13 years ago
Attachment #145508 - Attachment description: patch for :first-node and :last-node → patch for :first-node and :last-node (checked in to trunk, 2004-04-07 16:25 -0700)
Attachment #145508 - Attachment is obsolete: true

Comment 8

13 years ago
shouldn't this bug be marked as RESOLVED FIXED?
(Assignee)

Comment 9

13 years ago
No.  Read comment 0.  And in general, read comment 0 on any bug before
commenting on it.

Updated

13 years ago
Keywords: fixed1.7
(Assignee)

Updated

13 years ago
Whiteboard: [whitebox][patch] → [whitebox]
(Assignee)

Updated

10 years ago
QA Contact: ian → style-system
(Assignee)

Comment 10

6 years ago
I think having a bug open on this is no longer useful.  I think we've been pretty good about ensuring this as part of the review process.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.