Closed
Bug 1452241
Opened 6 years ago
Closed 6 years ago
Improve feed error handling and logging
Categories
(bugzilla.mozilla.org :: Phabricator Integration, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dylan, Assigned: dkl)
References
()
Details
Attachments
(1 file)
The feed should handle bad data from phabricator (such as invalid bug ids) and also many logging messages should be WARN or ERROR instead of DEBUG.
Reporter | ||
Comment 1•6 years ago
|
||
I'm going to let dkl handle this, as he has better idea of needs. dkl: I think you need to do two things here -- when you get a bad transaction from phabricator, such as one about a bug that doesn't exist, you need to either fail very loudly (enough that ckolos would be altered), OR you need to skip the bad data. Also the logging messages should be re-leveled, so that with log level INFO (the default) the output is useful. It looks like me like several of the DEBUG-type statements are better suited as WARN or even ERROR(). sort of like this: TRACE -- used in development when want to follow execution flow in detail DEBUG -- used only in development when you're trying to see what is going on NOTICE/INFO -- the program did something useful ("I processed six jobs!") WARN -- something odd happened ("This phabricator revision is weird" ERROR -- an error happened, but you were able to handle it FATAL -- an error happened, and you have no idea how the program can proceed.
Assignee: dylan → dkl
Assignee | ||
Updated•6 years ago
|
Reporter | ||
Comment 2•6 years ago
|
||
please attach the PR to this bug
Status: NEW → ASSIGNED
Flags: needinfo?(dkl)
Assignee | ||
Comment 3•6 years ago
|
||
Flags: needinfo?(dkl)
Assignee | ||
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•