1458162 - Fix test test_pluginInfoURL.js fix and change blocklist preferences to thunderbird.net redirects

Status: RESOLVED FIXED

(Toolkit :: Blocklist Implementation, defect)

Description

[Andrei Hajdukewycz [:sancus]]

In Bug 1457745 we removed the Thunderbird-specific blocklist prefs. In the future there's a chance we'll be hosting the blocklist ourselves, and pointing directly at the Mozilla cdn makes this more difficult to change.

I've set up some redirects in https://github.com/thundernest/live-redirects/commit/857f0cb650f4b5adfde248dec9f33071cddb5f9c and if we use these instead, changing where Thunderbird looks for this data is much faster and simpler.

Comment 1

[Andrei Hajdukewycz [:sancus]]

Attachment: Bug_1458162.patch

Comment 2

[Andrei Hajdukewycz [:sancus]]

Attachment: test_infoURL_missing fix

This fixes the test so it depends on the pref and isn't hardcoded.

Comment 3

[Andrei Hajdukewycz [:sancus]]

Comment on attachment 8972251 [details] [diff] [review]
test_infoURL_missing fix

I'm not sure if you're the right person to r? for this, Gijs, but if not could you redirect it? And of course let me know if there's any issue with altering the test in this way.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8972248 [details] [diff] [review]
Bug_1458162.patch

Thanks for picking this up so quickly. I hope all those URLs work ;-)

Comment 5

[Jorg K (CEST = GMT+2)]

Oh, you need to put the bug number into the commit message:
Bug xxx - such and such. r=yyy
No worries for the C-C patch, I'll fix that, but for M-C you need to upload a new patch. You can do it after the review and add the reviewer. You then set r+ yourself and write: Carrying over yyy's r+.

Comment 6

[Andrei Hajdukewycz [:sancus]]

Ah OK, no problem. And yes I hope the URLs work too ;)

Comment 7

[:Gijs (he/him)]

Comment on attachment 8972251 [details] [diff] [review]
test_infoURL_missing fix

Review of attachment 8972251 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM with the commit message fixed to include a bug number etc.

Comment 8

[Andrei Hajdukewycz [:sancus]]

Attachment: mozilla-central test_infoURL_missing fix

Thanks. I've updated the commit message as requested to include Bug number and r=gijs. Will need someone to check it in for me, of course.

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 8972258 [details] [diff] [review]
mozilla-central test_infoURL_missing fix

Carrying forward Gijs' r+

Comment 10

[Jorg K (CEST = GMT+2)]

Dear sheriff, please land the mozilla-central part for us.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6876bbcd3c3f
Change xpcshell test toolkit/mozapps/extensions/test/xpcshell/test_pluginInfoURL.js to use blocklist pref for test_infoURL_missing. r=Gijs

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/479f02e12da2
Change blocklist prefs to use live.thunderbird.net redirects. r=jorgk DONTBUILD

Comment 13

[Jorg K (CEST = GMT+2)]

Beta (TB 60 beta 6):
https://hg.mozilla.org/releases/comm-beta/rev/25ca94de86cfc28bc51177785f96864ce18ea323

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6876bbcd3c3f