Closed Bug 1458162 Opened 2 years ago Closed 2 years ago

Fix test test_pluginInfoURL.js fix and change blocklist preferences to redirects


(Toolkit :: Blocklist Implementation, defect)

Not set





(Reporter: sancus, Assigned: sancus)



(2 files, 1 obsolete file)

In Bug 1457745 we removed the Thunderbird-specific blocklist prefs. In the future there's a chance we'll be hosting the blocklist ourselves, and pointing directly at the Mozilla cdn makes this more difficult to change.

I've set up some redirects in and if we use these instead, changing where Thunderbird looks for this data is much faster and simpler.
Assignee: nobody → sancus
Attached patch test_infoURL_missing fix (obsolete) — Splinter Review
This fixes the test so it depends on the pref and isn't hardcoded.
Attachment #8972248 - Flags: review?(jorgk)
Attachment #8972248 - Flags: approval-comm-beta?
Comment on attachment 8972251 [details] [diff] [review]
test_infoURL_missing fix

I'm not sure if you're the right person to r? for this, Gijs, but if not could you redirect it? And of course let me know if there's any issue with altering the test in this way.
Attachment #8972251 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8972248 [details] [diff] [review]

Thanks for picking this up so quickly. I hope all those URLs work ;-)
Attachment #8972248 - Flags: review?(jorgk)
Attachment #8972248 - Flags: review+
Attachment #8972248 - Flags: approval-comm-beta?
Attachment #8972248 - Flags: approval-comm-beta+
Oh, you need to put the bug number into the commit message:
Bug xxx - such and such. r=yyy
No worries for the C-C patch, I'll fix that, but for M-C you need to upload a new patch. You can do it after the review and add the reviewer. You then set r+ yourself and write: Carrying over yyy's r+.
Ah OK, no problem. And yes I hope the URLs work too ;)
Comment on attachment 8972251 [details] [diff] [review]
test_infoURL_missing fix

Review of attachment 8972251 [details] [diff] [review]:

LGTM with the commit message fixed to include a bug number etc.
Attachment #8972251 - Flags: review?(gijskruitbosch+bugs) → review+
Thanks. I've updated the commit message as requested to include Bug number and r=gijs. Will need someone to check it in for me, of course.
Attachment #8972251 - Attachment is obsolete: true
Keywords: checkin-needed
Comment on attachment 8972258 [details] [diff] [review]
mozilla-central test_infoURL_missing fix

Carrying forward Gijs' r+
Attachment #8972258 - Flags: review+
Dear sheriff, please land the mozilla-central part for us.
Component: Preferences → Blocklisting
Flags: approval-comm-beta+
Product: Thunderbird → Toolkit
Summary: Change blocklist preferences to redirects → Fix test test_pluginInfoURL.js fix and change blocklist preferences to redirects
Version: unspecified → Trunk
Pushed by
Change xpcshell test toolkit/mozapps/extensions/test/xpcshell/test_pluginInfoURL.js to use blocklist pref for test_infoURL_missing. r=Gijs
Keywords: checkin-needed
Pushed by
Change blocklist prefs to use redirects. r=jorgk DONTBUILD
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: Blocklist Policy Requests → Blocklist Implementation
You need to log in before you can comment on or make changes to this bug.