160486 - 'Replace and Find' button gives double 'not found' dialog

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Ivo Jansch]

Comment 1

[Ivo Jansch]

In the 'Find and Replace' dialog, there's a button 'Replace and Find'.

If I enter a text that cannot be found, and I press 'Replace and Find', I get 2
popups saying that the text cannot be found.

Comment 2

[Kathleen :Brade]

-->akkana

Comment 3

[Harry Lu]

The reason is that if current selection doesn't match the search str, 
onFindNext() will be called twice. This is wrong.

Comment 4

[Kyle Yuan]

maybe you can fix it before we go gym?

Comment 5

[Harry Lu]

Attachment: don't call onFindNext() in onReplace()

I think we don't need to call onFindNext() in onReplace(). Click Replace button
should do nothing if current selection doesn't match the select str. User
should use Find button to do the find.
Akkana, what do you think of it?

Comment 6

[Akkana Peck]

Yes, quite right.  r=akkana.  Thanks, Harry!  Kin, can you sr this?  It's a
one-line patch.

Comment 7

[Akkana Peck]

Argh -- this never got a super-review!  Simon, can you please sr this one-line
patch?

Comment 8

[Simon Fraser [no longer active]]

Comment on attachment 93678 [details] [diff] [review]
don't call onFindNext() in onReplace()

sr=sfraser

Comment 9

[Akkana Peck]

Checked in.