194234 - land venkman 0.9.48

Status: VERIFIED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Robert Ginda]

Attached patch fixes the following problems...

ASSERTs in debug builds caused by calling the window.alert, prompt, and confirm
functions from chrome.  Instead, we write our own functions in terms of the
prompt service.

Inability to set any kind of breakpoint in a file loaded from "Open File" or
"Open Web Location".

Adds "Add Watch Expression..." to the context menu of the Watch view.

The patch has been available as an XPI since the 14th.  A regression related to
the new prompt command was discovered and fixed on the 19th.  No other problems
have been found, and of course, the patch doesn't change anything outside of
extensions/venkman.  I'd like to check this in for 1.3 final.

Comment 1

[Robert Ginda]

Attachment: changes for venkman 0.9.48

Comment 2

[Asa Dotzler [:asa]]

Comment on attachment 115018 [details] [diff] [review]
changes for venkman 0.9.48

a=asa (on behalf of drivers) for checkin to 1.3.

Comment 3

[Robert Ginda]

checked in.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

rs verifying these land venkman "0.9.x" bugs -- latest version is now well past
these guys.