303830 - Weekly recurrence doesn't work properly

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Robin Edrenius]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050806 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050807 Mozilla Sunbird/0.2+

The weekly recurrence only repeats the event on the weekday the first event was
created (i.e if the startday on the first event is on a sunday, it will only
repeat on sundays, even if you select more weekdays)

Reproducible: Always

Steps to Reproduce:
1. Create a event
2. Select weekly recurrence
3. Select multiple weekdays

Actual Results:  
The event is only repeated on the weekday of were the original event was created

Expected Results:  
The event should be repeated on the weekdays that is specified in the recurrence
options for that event.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

I think the problem is the same as described in bug 304515 comment 3 and 4.
Setting dependency for now, might turn out to be a duplicate.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

When editing the event, are the checkboxes still checked?
And which provider are you using? If it's a local calendar (storage), can you
try a remote calendar (ics, you can use a file:// patch to make it not-so remote)

Comment 3

[Talisein]

I'm having the same problem. I am using Mozilla/5.0 (X11; U; Linux i686; en-US;
rv:1.7.10) Gecko/20050723, the August 22nd build. When I create a recurring
weekly event on a local calander, after I push Okay to create the event, it
recurrs for the first event weekly, but not the other boxes I selected. Editting
the event shows that the boxes are no longer selected.

Using the same build on a (file://) remote calender, the weekly recurring event
function does work as advertised. 

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: simple patch

no need to comment on the patch...

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 193724 [details] [diff] [review]
simple patch

r=dmose

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in. The storage calendar should work properly now.

Comment 7

[Joey Minta]

This patch seems to create some very bad problems for me.  With clean profile, I
created a weekly, recurring event.  This results in several copies of:

Error: row[rtypes[i]].split is not a function
Source File:
file:///home/joey/mozhack/mozilla/sunobj2/dist/bin/components/calStorageCalendar.js
Line: 1276

Recuring events created prior to the implementation of this patch are still
dealt with ok.  Only events created/edited after this patch went in cause this
problem.

Re-opening bug.

Comment 8

[Joey Minta]

I should also say that the terminal outputs:
XXXX Expected to find recurrence, but got no items!

Comment 9

[Joey Minta]

Attachment: handle single integer case

Since we're dealing with integers, .split fails if there is only one.  This
patch handles that case.

Comment 10

[Joey Minta]

Attachment: better patch

toString() makes things much simpler :-)

r=dmose from IRC

Comment 11

[Joey Minta]

Patch checked in.