395543 - Remove dummyWindow

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch

Silly hack from 2001, quietly moved to browser/ by ben in '04, hasn't been used since '05.
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/browser/components/shell/src/nsSetDefaultBrowser.js&rev=HEAD&mark=1.5
http://lxr.mozilla.org/seamonkey/search?string=dummyWindow

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 280214 [details] [diff] [review]
Patch

cvs rm the file as well?

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

(In reply to comment #1)
> (From update of attachment 280214 [details] [diff] [review])
> cvs rm the file as well?
> 

My working tree is anonymous and MozillaBuild doesn't package cvsdo, but I'll be sure to do it on checkin :)

Comment 3

[:Gavin Sharp [email: [e-mail]]]

All my trees are anonymous, I use "cvs -d :ext:[e-mail]:/cvsroot" :)

Comment 4

[Ryan Flint [:rflint] (ping via IRC for reviews)]

mozilla/browser/components/shell/jar.mn 1.5
mozilla/browser/components/shell/content/dummyWindow.xul delete

Comment 5

[u88484]

Any chance this fixes bug 395255?  Sorry if it is way off base but I can't always reproduce that crash so I wouldn't really be able to tell if this fixed it or not.  Sorry if they are not even remotely related!

Comment 6

[Ryan Flint [:rflint] (ping via IRC for reviews)]

(In reply to comment #5)
> Any chance this fixes bug 395255?  Sorry if it is way off base but I can't
> always reproduce that crash so I wouldn't really be able to tell if this fixed
> it or not.  Sorry if they are not even remotely related!
> 
Nope, the only thing in common is a similar name :)