405786 - 1.9 doesn't detect powerpc correctly

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Raúl Porcel]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.9) Gecko/20071103 Firefox/2.0.0.9
Build Identifier: 

Due to the apply of bug 372428, $OS_TEST on powerpc now returns 'powerpc', and xpcom Makefile expects 'ppc'.

Reproducible: Always

Comment 1

[Raúl Porcel]

Attachment: ppc.patch

Patch :)

Comment 2

[Alexander Sack]

we ship this patch in ubuntu ... the build succeeds.

Comment 3

[Raúl Porcel]

Comment on attachment 290526 [details] [diff] [review]
ppc.patch

Index: xpcom/reflect/xptcall/src/md/unix/Makefile.in
===================================================================
RCS file: /cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v
retrieving revision 1.95
diff -u -b -B -u -8 -p -r1.95 Makefile.in
--- xpcom/reflect/xptcall/src/md/unix/Makefile.in	9 Nov 2007 18:53:21 -0000	1.95
+++ xpcom/reflect/xptcall/src/md/unix/Makefile.in	28 Nov 2007 14:32:02 -0000
@@ -273,17 +273,17 @@ endif
 
 # #24617  Building the CPP's (CXX) optimized causes a crash
 CXXFLAGS 	:=  $(filter-out $(MOZ_OPTIMIZE_FLAGS), $(CXXFLAGS))
 endif
 
 #
 # Linux/PPC
 #
-ifeq ($(OS_ARCH)$(OS_TEST),Linuxppc)
+ifeq ($(OS_ARCH)$(OS_TEST),Linuxpowerpc)
 CPPSRCS		:= xptcinvoke_ppc_linux.cpp xptcstubs_ppc_linux.cpp
 ASFILES		:= xptcinvoke_asm_ppc_linux.s xptcstubs_asm_ppc_linux.s
 AS		:= $(CC) -c -x assembler-with-cpp
 endif
 
 #
 # NetBSD/PPC
 #

Comment 4

[Raúl Porcel]

Attachment: ppc.patch

Sigh, there goes. Sorry for the bugspam :)

Comment 5

[timeless]

Comment on attachment 290530 [details] [diff] [review]
ppc.patch

ok, fedora, ubuntu (and in a quirky way gentoo) all reached the same conclusion at about the same time.

Comment 6

[Reed Loden [:reed]]

Checking in xpcom/reflect/xptcall/src/md/unix/Makefile.in;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v  <--  Makefile.in
new revision: 1.96; previous revision: 1.95
done