436326 - SNAV fails to get 'content window' on fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Antonio Gomes (tonikitoo)]

svan tries often to get a 'window content' from a 'chrome window' object [1], but if we try to make snav to work on fennec. 

[1] http://lxr.mozilla.org/seamonkey/source/extensions/spatialnavigation/src/nsSpatialNavigation.cpp#840

fwiw, the same code works fine on Firefox 3 (with patch https://bugzilla.mozilla.org/attachment.cgi?id=322650 applied)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: Make sure we use type="content-primary" when needed

I am fairly certain that nsGlobalWindow::GetContent eventually needs the <browser> to have a type="content-primary". This patch sets the type correctly when needed.

Comment 2

[Antonio Gomes (tonikitoo)]

mfinkle, patch virified. SNAV worked fine after. Thanks.

btw, is it supposed to fix bug 435446 ? should we add a dep here ?

Comment 3

[Doug Turner (:dougt)]

this has been fixed in the latest fennec.

Comment 4

[Anna (Waverley)]

VERIFIED FIXED:

Build ID: Mozilla/5.0 (Maemo; Linux armv7l; rv:6.0a1) Gecko/20110510
Firefox/6.0a1 Fennec/6.0a1

Device: Nokia N900 (Maemo GTK)