451546 - Link annotations to file diff instead of parent's annotate

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Dirkjan Ochtman (:djc)]

Attachment: hg export for the revision that fixes this

People are complaining that the annotate per-line links link to the annotation of the parent revision, whereas it maybe more useful when pointing to the file diff for that parent revision (like it was in bonsai).

I have a patch at http://hg.xavamedia.nl/mozilla/moz-templates/rev/34689b5aab83, which chould be pulled into the canonical mozilla repo and then deployed (also attaching it for review).

(This would include a simple email obfuscation patch for the pushlog, which I could remove again if deemed unwanted.)

Comment 1

[Dirkjan Ochtman (:djc)]

Comment on attachment 334869 [details] [diff] [review]
hg export for the revision that fixes this

Ted, can you review this?

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 334869 [details] [diff] [review]
hg export for the revision that fixes this

wfm

Comment 3

[Dirkjan Ochtman (:djc)]

Aravind, can you get this deployed? (Updated templates.)

Comment 4

[(not currently active) Ted Mielczarek]

Usually we file a new bug in mozilla.org : server operations on deployment. You can CC aravind.

Comment 5

[Aravind Gottipati [:aravind]]

Ted: Can you merge this into hg_templates?

Comment 6

[Reed Loden [:reed]]

Let's keep this bug separate and have ted/djc file a new server-ops bug when they are ready to get this deployed. Otherwise, it makes it difficult to find the bugs where these changes come from.

Comment 7

[Dirkjan Ochtman (:djc)]

reed: sorry, was already told by ted/bsmedberg to file a separate bug. Will do that later, some more stuff is waiting for review.

Comment 8

[Dirkjan Ochtman (:djc)]

This has been deployed.