Closed
Bug 483019
Opened 15 years ago
Closed 15 years ago
no need for Math.abs when multiplying two numbers together.
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dougt, Assigned: dougt)
Details
Attachments
(1 file, 1 obsolete file)
|
1.29 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
if ((Math.abs(dx*dx) + Math.abs(dy*dy)) > 100) {
should just be
if (dx*dx + dy*dy > 100) {
Attachment #367091 -
Flags: review?(gavin.sharp)
|
Assignee | |
Updated•15 years ago
|
Attachment #367091 -
Attachment is obsolete: true
Attachment #367091 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: nobody → doug.turner
Attachment #367093 -
Flags: review?
|
|
Assignee | |
Updated•15 years ago
|
Attachment #367093 -
Flags: review? → review?(gavin.sharp)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 367093 [details] [diff] [review] patch v.1 (that works) MikeK was fixing this in bug 456621, but sure, go ahead and bitrot him!
Attachment #367093 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
i <3 MikeK changeset: 430:50222518eb3b tag: tip user: Doug Turner <dougt@meer.net> date: Fri Mar 13 14:11:02 2009 -0700 summary: 483019. no need for Math.abs when multiplying two numbers together. r=gavin
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•