494111 - TM: many math trace tests fail on 1.9.1 branch

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Graydon Hoare :graydon]

It seems due to the absence of tinderbox-integrated unit-testing of trace-test.js, and the fact that most of the JS team is working on TM branch not 1.9.1 branch, we've let the 1.9.1 branch slip into "not passing" for a number of tests that touch Math. Most of the trig, abs, ceil, etc. tests fail.

Will need to isolate and fix, this should block.

Comment 1

[Graydon Hoare :graydon]

Note also that landing bug 473989 -- making trace-test.js run as part of tinderbox -- would be keen as well.

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

yeah, math matters.

Comment 3

[Andreas Gal :gal]

Dropping blocking (not sure what the protocol is and whether its ok for me to do that myself, but hey its 2am).

The trunk version of trace-tests.js passes fine. branch has an outdated test harness. I suggest copying over the trunk version once all related fixes have been merged (right now testNewArrayCount2 fails on branch, because the corresponding fix hasn't landed on branch yet).

Assigning to graydon since he was fiddling with running tests automatically. Assign back to me if unwanted, but should be general@js.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Andreas: I'm happy to leave this off the blocker list as long as you guarantee me that this will happen before we ship the RC. We need to make sure that we have the right tests testing 191 before we can freeze.

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Bob: can you help us get trace-tests on 1.9.1 updated and covered?  This sort of thing sets my spidey sense on _fire_, and you have the diligence and thoroughness we need at this stage of the game. :)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Two years later, safe to say WONTFIX?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

3 months and no response. 1.9.1 is no longer a supported branch.