52476 - Incorrect build ID in Warpzilla titlebar

Status: CLOSED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Barry Marshall]

Tested with Warpzilla nightly build 0912 on WSeB base with Scitech DD 
on TP770X.

1) Start Warpzilla
2) Help - About Mozilla

The build ID in the Title Bar and on this page don't match.

Comment 1

[Barry Marshall]

Attachment: Note the two different build ID's

Comment 2

[Mike Kaply [:mkaply]]

Two fold problem here:

1. MOZILLA_OFFICIAL should be set on our nightly build machine.

2. The aboutime.pl script in mozilla/config is not working correctly on OS/2.

I sent a note to our build person about 1

2 is being hashed out on IRC - probably to be fixed by jag

Comment 3

[Mike Kaply [:mkaply]]

Our main problem here is that aboutime.pl in config assumes that the platform 
rename will succeed if the destination exists.

This is bad.

aboutime.pl should delete the destination file before attempting the rename.

Comment 4

[Barry Marshall]

Is M18 reasonable for this?

Comment 5

[cls]

mkaply, see if this fixes it for you.

Index: config/aboutime.pl
===================================================================
RCS file: /cvsroot/mozilla/config/aboutime.pl,v
retrieving revision 3.4
diff -u -r3.4 aboutime.pl
--- aboutime.pl 1999/08/24 00:56:04     3.4
+++ aboutime.pl 2000/09/19 18:31:08
@@ -26,4 +26,5 @@
 close INFILE;
 close OUTFILE;
 
+unlink $ARGV[0];
 rename "$ARGV[0].old", "$ARGV[0]";

Comment 6

[Mike Kaply [:mkaply]]

That diff fixes my problem.

Comment 7

[Mike Kaply [:mkaply]]

r=mkaply

Comment 8

[cls]

Fix has been checked in.

Comment 9

[Jon Granrose]

verified.

Comment 10

[Barry Marshall]

Yup, I'm happy.  Let's close 'er up.