Closed
Bug 605442
Opened 14 years ago
Closed 14 years ago
Pref to disable fullscreen
Categories
(Mozilla Labs :: Prism, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: matthew.gertner, Assigned: matthew.gertner)
Details
Attachments
(1 file)
|
661 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Some applications might not want to use the fullscreen keyboard shortcut.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #484285 -
Flags: review?(mark.finkle)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 484285 [details] [diff] [review] Add prism.shortcut.fullScreen.disable pref prefs.getBoolPref will throw an exception if the pref is not found. You should add this pref to the preferences JS file too, defaulted to false. Or you can wrap the code in a try/catch r+ with nit fixed
Attachment #484285 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
I did change preferences.js but I forgot to include it in the patch. Replacing chrome/content/webrunner.js Sending defaults/preferences/preferences.js Transmitting file data .. Committed revision 75956.
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•