Closed Bug 650246 Opened 13 years ago Closed 13 years ago

Replace %APP% with firefox in firefox preferences

Categories

(Firefox :: Settings UI, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 6

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(2 files)

Attached patch PatchSplinter Review
This is something I have been doing for a while on Debian, where %APP% resolves to iceweasel, yet hadn't bothered filing a bug until now that I saw bug 602367 comment 15:

>> Why aren't we using '?src=%APP%' here?
>
> It's in the Firefox prefs so I don't think there is much to be gained from
> changing that now.

With the same rationale, it should be safe to replace %APP% with firefox in the same file.
Attachment #526227 - Flags: review?(dtownsend)
Comment on attachment 526227 [details] [diff] [review]
Patch

My comment was more because we were pushed for time so I didn't think it worth bothering with, not necessarily that we should do it everywhere but I'll let one of the browser peers make that call.
Attachment #526227 - Flags: review?(dtownsend) → review?(gavin.sharp)
Attachment #526227 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mozilla-central/rev/9e31df64bfd7
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Assignee: nobody → mh+mozilla
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: