664017 - Static docs don't render properly on IE9

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect)

Description

[Will Bamberg [:wbamberg]]

1) IE9 does not support JavaScript's 'const' keyword, so main.js fails, with predictable results. Changing it to 'var' fixes the problem.

2) IE9 does not wrap the list of modules: there is something about the inline display of the <li> elements that it does not like. I'm not sure what the correct fix is: a simple fix would be not to set the display to inline on IE only, so it would only display a single module per line.

I'm not sure if this affects the severity, but these are not regressions: they have been present forever.

Comment 1

[Will Bamberg [:wbamberg]]

Attachment: Conditional css to make IE rendering work OK

This is kind of a hacky patch, but it's the least-disruptive way I can think of to make the docs render tolerably well on IE.

I've also put the static docs built with this up on to members.shaw.ca/vill/sdk

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 539224 [details] [diff] [review]
Conditional css to make IE rendering work OK

r=myk, and a=myk for commission during freeze, although drivers'll probably mark this a blocker.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Not a blocker, as it doesn't sound like a common-enough case for our developer audience, but we'll still take the patch as a low-risk ride-along.

Comment 4

[Will Bamberg [:wbamberg]]

Landed in: https://github.com/mozilla/addon-sdk/commit/2386171723de995c22e07a6875d988867baf6b9d