673086 - Fix the repack-l10n-all target and call it from release automation

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

In lightning/Makefile.in we have a target that should repack lightning.xpi to contain all locales. An error occurs doing this because it attempts to find the locale "all" and repackage it.

Executing these steps manually works though:

make L10N_XPI_NAME=lightning-all AB_CD=all repack-clobber-all
for i in $(<...shipped-locales...); do make L10N_XPI_NAME=lightning-all AB_CD=all libs-$i; done

(Although it should be solved more make-ish)

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

We should also make sure this target is called from release automation, see bug 673089.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Makefiles fixes - v1

This patch takes care of the Makefile, now we only need to call the target from release automation.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 556512 [details] [diff] [review]
Makefiles fixes - v1

Not tested this, but it looks fine.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/d09d9865a8ac>
-> FIXED

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-aurora <http://hg.mozilla.org/releases/comm-aurora/rev/ff331d4a33a8>

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-beta <http://hg.mozilla.org/releases/comm-beta/rev/dce479d8d807>

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Of course not fixed, leaving open for the release automation side.

Comment 8

[Mark Banner (:standard8)]

Philipp, do the locale repositories need pulling separately in some form, which directory do they need to go in?

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Yes, they need to be pulled separately and be placed wherever the --with-l10n-base configure option points to.

When doing manual repacks, I chose ../l10n-branchname. Note that on mac there needs to be one more .. because of the i386 platform subdir. Its probably better to use an absolute path there.

Comment 10

[Mark Banner (:standard8)]

Automation done in bug 685133.