Closed Bug 673086 Opened 9 years ago Closed 8 years ago

Fix the repack-l10n-all target and call it from release automation

Categories

(Calendar :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file)

In lightning/Makefile.in we have a target that should repack lightning.xpi to contain all locales. An error occurs doing this because it attempts to find the locale "all" and repackage it.

Executing these steps manually works though:

make L10N_XPI_NAME=lightning-all AB_CD=all repack-clobber-all
for i in $(<...shipped-locales...); do make L10N_XPI_NAME=lightning-all AB_CD=all libs-$i; done

(Although it should be solved more make-ish)
We should also make sure this target is called from release automation, see bug 673089.
Summary: Fix the repack-l10n-all target → Fix the repack-l10n-all target and call it from release automation
Attached patch Makefiles fixes - v1 β€” β€” Splinter Review
This patch takes care of the Makefile, now we only need to call the target from release automation.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #556512 - Flags: review?(mbanner)
Comment on attachment 556512 [details] [diff] [review]
Makefiles fixes - v1

Not tested this, but it looks fine.
Attachment #556512 - Flags: review?(mbanner) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/d09d9865a8ac>
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
Backported to comm-aurora <http://hg.mozilla.org/releases/comm-aurora/rev/ff331d4a33a8>
Target Milestone: Trunk → 1.0b6
Of course not fixed, leaving open for the release automation side.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Philipp, do the locale repositories need pulling separately in some form, which directory do they need to go in?
Yes, they need to be pulled separately and be placed wherever the --with-l10n-base configure option points to.

When doing manual repacks, I chose ../l10n-branchname. Note that on mac there needs to be one more .. because of the i386 platform subdir. Its probably better to use an absolute path there.
Automation done in bug 685133.
Status: REOPENED → RESOLVED
Closed: 9 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.