Fix the repack-l10n-all target and call it from release automation

RESOLVED FIXED in 1.0b7

Status

Calendar
Build Config
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

unspecified
1.0b7

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
In lightning/Makefile.in we have a target that should repack lightning.xpi to contain all locales. An error occurs doing this because it attempts to find the locale "all" and repackage it.

Executing these steps manually works though:

make L10N_XPI_NAME=lightning-all AB_CD=all repack-clobber-all
for i in $(<...shipped-locales...); do make L10N_XPI_NAME=lightning-all AB_CD=all libs-$i; done

(Although it should be solved more make-ish)
(Assignee)

Updated

6 years ago
Blocks: 673089
(Assignee)

Comment 1

6 years ago
We should also make sure this target is called from release automation, see bug 673089.
Summary: Fix the repack-l10n-all target → Fix the repack-l10n-all target and call it from release automation
(Assignee)

Comment 2

6 years ago
Created attachment 556512 [details] [diff] [review]
Makefiles fixes - v1

This patch takes care of the Makefile, now we only need to call the target from release automation.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #556512 - Flags: review?(mbanner)
Comment on attachment 556512 [details] [diff] [review]
Makefiles fixes - v1

Not tested this, but it looks fine.
Attachment #556512 - Flags: review?(mbanner) → review+
(Assignee)

Comment 4

6 years ago
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/d09d9865a8ac>
-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
(Assignee)

Comment 5

6 years ago
Backported to comm-aurora <http://hg.mozilla.org/releases/comm-aurora/rev/ff331d4a33a8>
Target Milestone: Trunk → 1.0b6
(Assignee)

Comment 6

6 years ago
Backported to comm-beta <http://hg.mozilla.org/releases/comm-beta/rev/dce479d8d807>
(Assignee)

Comment 7

6 years ago
Of course not fixed, leaving open for the release automation side.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Philipp, do the locale repositories need pulling separately in some form, which directory do they need to go in?
(Assignee)

Comment 9

6 years ago
Yes, they need to be pulled separately and be placed wherever the --with-l10n-base configure option points to.

When doing manual repacks, I chose ../l10n-branchname. Note that on mac there needs to be one more .. because of the i386 platform subdir. Its probably better to use an absolute path there.
Automation done in bug 685133.
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.