689777 - Allow retrieving addon/test output when run on android device

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Alexandre Poirot [:ochameau]]

Bug 688651 introduce preliminary Android devices support in cfx,
but I delayed implementation of addon run or tests execution console messages.
Being able to run an addon on the device is already cool, but it would be even easier if we can see messages directly through cfx command line, instead of going in device JS console.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 244

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 565221 [details]
Pull request 244

This patch is finally ready for review.
It was based on top of the very first pull request about mobile support,
and should have landed way sooner but I almost forgot about this work.
The patch has been merge with last master and adapted to last mobile work done by Matteo.

If you want to play with it, connect an Android thing (with a fennec nightly instellad) and create a naive addon that just do some console.log(), then run:
  
  $ cfx run --force-mobile -a fennec-on-device -b /path/to/adb/executable

You may have to add "-m firefox_nightly" if you have multiple version of fennec installed.

Comment 3

[Brian Warner [:warner :bwarner]]

Comment on attachment 565221 [details]
Pull request 244

looked good to me.. r+ with a few minor comments on the pull-request

Comment 4

[[github robot]]

Commit pushed to https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/b34e5f742e7c12c3d2f870fc94f53052a0e75345
Merge pull request #244 from ochameau/device-log

Bug 689777: Allow retrieving addon/test output when run on android device r=@warner

Comment 5

[ramesh]

fkjfkljfdjlkfdjklfdjkfdjklfdjklgjlkfdrpoerekjklfdjkljgnvcxmndfjklgneiojnersjg;prjokgf;okjfdl;gjlkfdjgklfdjgrpoirepjklfjfkldjgrepoklfjgklfdjklfdjgf