697076 - Fix Clang warnings

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

This patch fixes a bunch of warnings like these:

1) jsinfer.cpp:350:5: warning: indirection of non-volatile null pointer will be deleted, not trap [-Wnull-dereference]
    *((int*)NULL) = 0;  /* Should never be reached */
    ^~~~~~~~~~~~~
jsinfer.cpp:350:5: note: consider using __builtin_trap() or qualifying pointer with 'volatile'

2) An unused parameter in editline.c

3) jswrapper.cpp:880:16: warning: explicit instantiation of 'js::SecurityWrapper' must occur in namespace 'js' [-Wc++0x-compat]
template class SecurityWrapper<Wrapper>;

With this patch there are still many warnings caused by the JS_DEFINE_CALLINFO_* macros. The fix there is not obvious so I'll just ignore them until the tracer is gone.

Comment 1

[David Bruant]

The summury gived the impression of a meta-bug. Is it?

Comment 2

[David Bruant]

The summury gives the impression of a meta-bug. Is it?

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 569344 [details] [diff] [review]
Patch

Thanks

Comment 4

[Jan de Mooij [:jandem]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/6780aa86cf87

Comment 5

[Jan de Mooij [:jandem]]

(In reply to David Bruant from comment #2)
> The summury gives the impression of a meta-bug. Is it?

No, it was not supposed to be a meta-bug :)

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6780aa86cf87