Closed
Bug 708797
Opened 13 years ago
Closed 13 years ago
The sync door hanger notification doesn't have a border when using classic or third-party themes
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 11
People
(Reporter: ehsan.akhgari, Assigned: soapy)
References
Details
Attachments
(2 files, 4 obsolete files)
25.65 KB,
image/png
|
Details | |
1.34 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
See the screenshot.
Comment 1•13 years ago
|
||
Comment on attachment 580155 [details]
Screenshot
This appears to be a different screenshot.
Assignee | ||
Comment 3•13 years ago
|
||
It appears the panel-promo-box has too much negative margins with Windows Classic theme and overlaps the border.
Comment 4•13 years ago
|
||
Comment on attachment 580627 [details] [diff] [review] Possible patch >+@media all and (-moz-windows-classic) { This is backwards, you need to use -moz-windows-default-theme. See the panel[type="arrow"] styles in <http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/popup.css>.
Updated•13 years ago
|
Summary: The sync door hander notification doesn't have a border on Windows XP → The sync door hanger notification doesn't have a border on Windows XP
Assignee | ||
Comment 5•13 years ago
|
||
Attachment #580627 -
Attachment is obsolete: true
Comment 6•13 years ago
|
||
Comment on attachment 580719 [details] [diff] [review] Possible patch v2 Is this correct for Windows XP? Note that popup.css uses -moz-windows-default-theme not just for WINSTRIPE_AERO.
Assignee | ||
Comment 7•13 years ago
|
||
This bug also affects Windows Classic on Windows 7 as well as third-party themes. Unless you were referring to the styling of the 'panel-promo-box'? It seems it was styled like Windows 7 style on all themes, even third-party ones. Is that the intended behavior?
Comment 8•13 years ago
|
||
I was referring to panel-promo-box on Windows XP Luna, which I suspect attachment 580719 [details] [diff] [review] breaks.
Summary: The sync door hanger notification doesn't have a border on Windows XP → The sync door hanger notification doesn't have a border when using classic or third-party themes
Assignee | ||
Comment 9•13 years ago
|
||
Fixed styling on Windows XP Luna.
Attachment #580719 -
Attachment is obsolete: true
Updated•13 years ago
|
Attachment #580736 -
Flags: review?(dao)
Comment 10•13 years ago
|
||
Comment on attachment 580736 [details] [diff] [review] Possible patch v3 > .panel-promo-box { >- margin: 8px -16px -16px -16px; >- padding: 8px 16px; >- background-color: #f1f5fb; >- color: GrayText; >+ margin: 8px -10px -10px; >+ padding: 8px 10px; This box is now transparent, so the padding plus the negative margin doesn't seem to make sense. How about: margin: 16px 0 -2px; > %ifndef WINSTRIPE_AERO > border-bottom-left-radius: 6px; > border-bottom-right-radius: 6px; > %endif This should move inside the -moz-windows-default-theme block.
Attachment #580736 -
Flags: review?(dao)
Assignee | ||
Comment 11•13 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #10) > Comment on attachment 580736 [details] [diff] [review] > Possible patch v3 > > > .panel-promo-box { > >- margin: 8px -16px -16px -16px; > >- padding: 8px 16px; > >- background-color: #f1f5fb; > >- color: GrayText; > >+ margin: 8px -10px -10px; > >+ padding: 8px 10px; > > This box is now transparent, so the padding plus the negative margin doesn't > seem to make sense. How about: > > margin: 16px 0 -2px; > > > %ifndef WINSTRIPE_AERO > > border-bottom-left-radius: 6px; > > border-bottom-right-radius: 6px; > > %endif > > This should move inside the -moz-windows-default-theme block. Added requested changes.
Attachment #580736 -
Attachment is obsolete: true
Updated•13 years ago
|
Attachment #582542 -
Flags: review+
Updated•13 years ago
|
Assignee: nobody → soapyhamhocks
Keywords: checkin-needed
Comment 12•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/e75f1076eab0
Keywords: checkin-needed
Target Milestone: --- → Firefox 11
Comment 13•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e75f1076eab0
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•